add DS3231 submodule to bundle #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
approved these changes
Aug 15, 2017
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you so much!
Contributor
|
https://github.com/adafruit/Adafruit_CircuitPython_DS3231 has no releases, so |
Member
|
Please do Dan. its an oversight on my part.
…On Tue, Aug 15, 2017 at 10:43 AM Dan Halbert ***@***.***> wrote:
https://github.com/adafruit/Adafruit_CircuitPython_DS3231 has no
releases, so ./update-modules.sh did not work for it. I can tag a release
if it's ready.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADNqTWG8HZ6Q8d8m31PR0u1kVzxt1Crks5sYdjMgaJpZM4O3ypr>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK i think I have added the ds3231 submodule to the circuitpython_bundle. If you think this is the wrong time for this, then just ignore it and i will do again at some future point. if you like it, i would like to work on the adafruit_circuitpython_max7219 git project. i that something I can do as well?